Skip to content

chmod: exit(1) if a file fails #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
briandfoy merged 1 commit into from
Nov 16, 2024
Merged

chmod: exit(1) if a file fails #814

briandfoy merged 1 commit into from
Nov 16, 2024

Conversation

@mknos
Copy link
Contributor

@mknos mknos commented Nov 15, 2024 •
edited
Loading

  • A failed chmod() is not a fatal error; the program will proceed to the next file argument but will exit(1) to indicate an error occurred
  • Do the same in modify_file() if a file doesn't exist (this helps exitcode match the GNU version)
  • Also introduce a regular usage() function

@mknos
chmod: exit(1) if a file fails
d270c46 
* A failed chmod() is not a fatal error; the program will proceed to the next file argument but will exit(1) to indicate an error
* Do the same in modify_file() if a file doesn't exist (this helps exitcode match the GNU version)
* Also introduce a regular usage() function
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: chmod The chmod program labels Nov 15, 2024
@mknos mknos temporarily deployed to automated_testing November 15, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 07:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 07:12 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11851895064

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.069%
Totals Coverage Status
Change from base Build 11850814828: 0.0%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy
Copy link
Owner

briandfoy commented Nov 16, 2024

changes: exit with 1 if a file fails

@briandfoy briandfoy merged commit d544a51 into briandfoy:master Nov 16, 2024
23 checks passed
@briandfoy briandfoy self-assigned this Nov 16, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted Type: compatability make it work like GNU or BSD and removed Priority: low get to this whenever labels Nov 16, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels

Program: chmod The chmod program Status: released there is a new release with this fix Type: compatability make it work like GNU or BSD Type: enhancement improve a feature that already exists

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mknos @coveralls @briandfoy